Feature/screen-root-style-bug - #6
Draft
tuj wants to merge 1 commit into
Draft
Conversation
tuj
added a commit
that referenced
this pull request
Aug 30, 2026
46d77aa straightened out what looked like a typo in screen.jsx: gridTemplateColumns was assigned gridTemplateRows and vice versa. The swap is load-bearing. createGrid() builds its outer array from its columns argument, and each quoted string it emits is a CSS row whose names are CSS columns, so the areas it returns are transposed relative to the argument names: createGrid(3, 2) yields 'a b' 'c d' 'e f', three CSS rows of two CSS columns. Assigning the track lists straight through leaves grid-template-areas declaring configColumns rows while grid-template-rows sizes configRows tracks. They agree only on square grids, and six of the nine layouts in assets/shared/screen-layouts are asymmetric — six-areas and touch-template (4x44), two-boxes-vertical and -reversed (1x5), three-boxes-horizontal (3x1), two-boxes (2x1). The same change was proposed upstream as os2display#389 and closed unmerged for this reason; it has its own branch here in #6, where fixing createGrid or the layout JSON convention belongs. The screen test pinned the regression and could not detect it, because createGrid is mocked there; it now asserts the compensated values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
os2display#389