Skip to content

Feature/screen-root-style-bug - #6

Draft
tuj wants to merge 1 commit into
release/3.0.0from
feature/screen-root-style-bug
Draft

Feature/screen-root-style-bug#6
tuj wants to merge 1 commit into
release/3.0.0from
feature/screen-root-style-bug

Conversation

@tuj

@tuj tuj commented Jun 2, 2026

Copy link
Copy Markdown

@tuj tuj self-assigned this Jun 2, 2026
@tuj tuj mentioned this pull request Aug 30, 2026
tuj added a commit that referenced this pull request Aug 30, 2026
46d77aa straightened out what looked like a typo in screen.jsx: gridTemplateColumns was assigned gridTemplateRows and vice versa. The swap is load-bearing. createGrid() builds its outer array from its columns argument, and each quoted string it emits is a CSS row whose names are CSS columns, so the areas it returns are transposed relative to the argument names: createGrid(3, 2) yields 'a b' 'c d' 'e f', three CSS rows of two CSS columns.

Assigning the track lists straight through leaves grid-template-areas declaring configColumns rows while grid-template-rows sizes configRows tracks. They agree only on square grids, and six of the nine layouts in assets/shared/screen-layouts are asymmetric — six-areas and touch-template (4x44), two-boxes-vertical and -reversed (1x5), three-boxes-horizontal (3x1), two-boxes (2x1).

The same change was proposed upstream as os2display#389 and closed unmerged for this reason; it has its own branch here in #6, where fixing createGrid or the layout JSON convention belongs. The screen test pinned the regression and could not detect it, because createGrid is mocked there; it now asserts the compensated values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant